Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty ado logs used to extract built images. #11132

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fix empty ado logs used to extract built images. #11132

merged 1 commit into from
Jun 26, 2024

Conversation

dekiel
Copy link
Contributor

@dekiel dekiel commented Jun 25, 2024 •
edited
Loading

Description

Fixing an image builder reusable workflow images output is empty bug.

Changes proposed in this pull request:

  • Fixed using local logs variable when getting logs from ado. The outer scope variable which was used to search for built images was empty.
  • Added checking errors returned from functions setting GitHub outputs.
  • Added info logging to track setting GitHub outputs progress.

@dekiel dekiel requested review from neighbors-dev-bot and a team as code owners June 25, 2024 12:41
@dekiel dekiel added the kind/bug Categorizes issue or PR as related to a bug. label Jun 25, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 25, 2024
@dekiel dekiel mentioned this pull request Jun 25, 2024
Open
1 task
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 26, 2024
@kyma-bot kyma-bot merged commit 2f46eb7 into kyma-project:main Jun 26, 2024
11 checks passed
@dekiel dekiel mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KacperMalachowski KacperMalachowski KacperMalachowski approved these changes

@neighbors-dev-bot neighbors-dev-bot Awaiting requested review from neighbors-dev-bot neighbors-dev-bot is a code owner

@Sawthis Sawthis Awaiting requested review from Sawthis Sawthis is a code owner automatically assigned from kyma-project/prow

Assignees

@dekiel dekiel

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dekiel @KacperMalachowski @kyma-bot